Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Opt out of tabIndex generation in samples and designer #4160

Merged
merged 3 commits into from
Jun 10, 2020

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Jun 9, 2020

Related Issue

Fixes VSO #23950535

Description

Consumes fix for #2236 (PR: #4020) on our site (designer as well as various samples).

How Verified

  • local build, devtools, and narrator
Microsoft Reviewers: Open in CodeFlow

@paulcam206 paulcam206 added the Area-Accessibility Bugs around feature accessibility label Jun 9, 2020
@paulcam206 paulcam206 requested review from dclaux and matthidinger June 9, 2020 22:05
@ghost
Copy link

ghost commented Jun 9, 2020

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@shalinijoshi19
Copy link
Member

/azp run AdaptiveCards-SharedModel-CI, AdaptiveCards-.NET-PR, AdaptiveCards-NodeJS-Daily, AdaptiveCards-UWP-Daily-PRs, AdaptiveCards-Android-CI, AdaptiveCards-iOS-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@paulcam206
Copy link
Member Author

/azp run AdaptiveCards-SharedModel-CI, AdaptiveCards-.NET-PR, AdaptiveCards-NodeJS-Daily, AdaptiveCards-UWP-Daily-PRs, AdaptiveCards-Android-CI, AdaptiveCards-iOS-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@paulcam206 paulcam206 merged commit d67632b into main Jun 10, 2020
@paulcam206 paulcam206 deleted the paulcam/designer-no-tabstops branch June 10, 2020 23:18
@shalinijoshi19 shalinijoshi19 added this to the 20.06 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants